add reconcile-reources flag
#176
Conversation
rushmash91
force-pushed
the
main
branch
2 times, most recently
from
3fac68b to
ed3b8b8
Compare
|
/retest |
ack-prow
bot
added
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
|
/retest |
|
/test sagemaker-controller-test |
|
/hold |
ack-prow
bot
added
the
do-not-merge/hold
|
/test sagemaker-controller-test |
|
@rushmash91: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/unhold |
ack-prow
bot
removed
the
do-not-merge/hold
Description of changes: aws-controllers-k8s/runtime#176 This PR adds template changes to support the reconcile-resources flag which was recently added to the ACK runtime. This flag allows users to specify which resource kinds should be reconciled by a controller, providing more granular control over controller behavior. When the flag is set, only the specified resource kinds will be reconciled by the controller. If unspecified, all resources will be reconciled (default behavior). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description of changes:
The AWS Controllers for Kubernetes (ACK) service controllers currently initialize reconcilers for all supported resource kinds, regardless of operational needs, leading to unnecessary resource consumption and potential for conflicts. We propose introducing a
--reconcile-resourcesflag that allows operators to specify which resource kinds should be actively reconciled, enabling more efficient resource utilization and operational control. When provided with a comma-separated list of resource kinds (e.g., "Queue,Topic"), the controller will only create reconcilers for those specific resources. This enhancement maintains backward compatibility by continuing to reconcile all resources when the flag is not specified.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.